Remove nightly requirement for no_std#184
Merged
est31 merged 1 commit intoRustAudio:masterfrom Nov 7, 2024
Merged
Conversation
est31
approved these changes
Mar 26, 2024
Member
|
This broke the CI and causes RMS values to be way off on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it is overkill that all
dasplibraries requireNightlyjust because there is nosqrt()function implementation for floating point types inno_stdenvironment.In my case, I just wanted to use the
Frametype, but compiler requires nightly.I did the same implementation to the sqrt() method as
micromathor this one that it was based on.https://github.com/tarcieri/micromath/blob/6de9df6943b6f06c087ab43ddc3523a379e00369/src/float/sqrt.rs#L13
https://bits.stephan-brumme.com/squareRoot.html
Adding micro_math to dependencies is a good idea, but if you think it is overkill, how about what I wrote?
What I wrote is just a suggestion, I believe the issue is that
dasprequiresNightlyif you try to use it inno_std.